Optimize icons #943
Optimize icons #943
Conversation
There was a problem hiding this comment.
Also moves most of these to live in the root assets/ directory, but no strong feelings about keeping them here vs. locally.
I generally keep them local when they are only used by a given component (in a local assets/) so that the component stays self contained. But for the illustrations, I agree it might make more sense to keep them all together. 👍
| import { useHelpScout } from '../../HelpScoutBeacon/useHelpScout' | ||
| import helpAndFeedbackPng from '../../../assets/help-and-feedback.png' |
There was a problem hiding this comment.
I'd say this one makes more sense locally, just like Pierre's comment, I try to keep assets locally for component's to be self-contained, when one asset is used more than once (only then) I move them to a global point of import.
| @@ -21,7 +21,7 @@ import { | |||
| import useBeaconSuggestions from './useBeaconSuggestions' | |||
| import { useHelpScout } from './useHelpScout' | |||
| import BeaconHeadScripts from './BeaconHeadScripts' | |||
| import headerImg from './header.png' | |||
| import helpScoutHeaderPng from '../../assets/help-scout-header.png' | |||
There was a problem hiding this comment.
Same here as other component.
|
I've moved the mentioned assets back into their local directories. I've opted to keep |
…tions * origin/newstyle: Optimize icons (#943) PropTypes: move fetch-required fields of AppType to be non-requi… (#946) Update ENS API changes from @aragon/wrapper (#944) Permissions: fix debounced search state on clearing filters (#942) Updates for aragonUI and other clean up (#939) AppCenter: update copy (#940)
Also moves most of these to live in the root
assets/directory, but no strong feelings about keeping them here vs. locally.