-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tooling: revert to React, React DOM & React scripts pre-React 17
While it would be great to update to the latest version of React and all its tooling, there seems to be an issue with typescript versions, react-scripts and the new JSX transform wreaking havoc on the JSX checks. While the issue was supposedly fixed here (facebook/create-react-app#9869), upgrading to react-scripts 4.0.1 doesn't fix the problem. Neither does upgrading AND pinning typescript to 4.0.5 so it doesn't overwrite the tsconfig.json file. Let's wait a few versions ahead for react-scripts so we can be sure this is fixed.
- Loading branch information
Showing
5 changed files
with
2,209 additions
and
2,053 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,25 @@ | ||
{ | ||
"include": ["src"], | ||
"compilerOptions": { | ||
"target": "es5", | ||
"jsx": "react", | ||
"allowSyntheticDefaultImports": true, | ||
"lib": ["dom", "dom.iterable", "esnext"], | ||
"lib": [ | ||
"dom", | ||
"dom.iterable", | ||
"esnext" | ||
], | ||
"allowJs": true, | ||
"skipLibCheck": true, | ||
"esModuleInterop": true, | ||
"allowSyntheticDefaultImports": true, | ||
"strict": true, | ||
"forceConsistentCasingInFileNames": true, | ||
"module": "esnext", | ||
"moduleResolution": "node", | ||
"resolveJsonModule": true, | ||
"isolatedModules": true, | ||
"noEmit": true | ||
} | ||
"noEmit": true, | ||
"jsx": "react" | ||
}, | ||
"include": [ | ||
"src" | ||
] | ||
} |
Oops, something went wrong.