Skip to content

Commit

Permalink
chore: fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
josemarinas committed May 2, 2024
1 parent 5ef9d5e commit 02e2b1a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion packages/contracts/test/framework/plugin/plugin-repo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ describe('PluginRepo', function () {

it('supports the `IPluginRepo` interface', async () => {
const iface = IPluginRepo__factory.createInterface();
expect(getInterfaceId(iface)).to.equal('0xd4321b40'); // the interfaceID from IPluginRepo v1.0.0
expect(getInterfaceId(iface)).to.equal('0x0d19035f');
expect(await pluginRepo.supportsInterface(getInterfaceId(iface))).to.be
.true;
});
Expand Down
11 changes: 0 additions & 11 deletions packages/contracts/test/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {IPermissionCondition__factory as IPermissionCondition_V1_0_0__factory} f
import {IPlugin__factory as IPlugin_V1_0_0__factory} from '../typechain/@aragon/osx-v1.0.1/core/plugin/IPlugin.sol';
import {IMembership__factory as IMembership_V1_0_0__factory} from '../typechain/@aragon/osx-v1.0.1/core/plugin/membership/IMembership.sol';
import {IProposal__factory as IProposal_V1_0_0__factory} from '../typechain/@aragon/osx-v1.0.1/core/plugin/proposal/IProposal.sol';
import {IPluginRepo__factory as IPluginRepo_V1_0_0__factory} from '../typechain/@aragon/osx-v1.0.1/framework/plugin/repo/IPluginRepo.sol';
import {IPluginSetup__factory as IPluginSetup_V1_0_0__factory} from '../typechain/@aragon/osx-v1.0.1/framework/plugin/setup/IPluginSetup.sol';
import {IMajorityVoting__factory as IMajorityVoting_V1_0_0__factory} from '../typechain/@aragon/osx-v1.0.1/plugins/governance/majority-voting/IMajorityVoting.sol';
import {IMultisig__factory as IMultisig_V1_0_0__factory} from '../typechain/@aragon/osx-v1.0.1/plugins/governance/multisig/IMultisig.sol';
Expand Down Expand Up @@ -90,16 +89,6 @@ describe('Interfaces', function () {
});
});

describe('IPluginRepo', function () {
it('has still the same interface ID', async () => {
const current = getInterfaceId(IPluginRepo__factory.createInterface());
const initial = getInterfaceId(
IPluginRepo_V1_0_0__factory.createInterface()
);
expect(current).to.equal(initial);
});
});

describe('IPluginSetup', function () {
it('has still the same interface ID', async () => {
const current = getInterfaceId(IPluginSetup__factory.createInterface());
Expand Down

0 comments on commit 02e2b1a

Please sign in to comment.