Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support pluralizable objects for default string #901

Open
wants to merge 5 commits into
base: canary
Choose a base branch
from
Open

Update to support pluralizable objects for default string #901

wants to merge 5 commits into from

Commits on Aug 24, 2022

  1. use same logic for default values, even if they are not strings

    @guscost-opensea
    guscost-opensea committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    9c317c6 View commit details
    Browse the repository at this point in the history

  2. fix default dictionary behavior, add test

    @guscost-opensea
    guscost-opensea committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e12107d View commit details
    Browse the repository at this point in the history

  3. safer pluralization rules

    @guscost-opensea
    guscost-opensea committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    c552052 View commit details
    Browse the repository at this point in the history

  4. fix regex

    @guscost-opensea
    guscost-opensea committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    72e48d1 View commit details
    Browse the repository at this point in the history

  5. more robust test

    @guscost-opensea
    guscost-opensea committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    3455582 View commit details
    Browse the repository at this point in the history