-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Ignore real and imaginary scans in ADNI #1029
Merged
NicolasGensollen
merged 5 commits into
aramis-lab:dev
from
NicolasGensollen:ignore-real-and-imaginary-scans-adni
Dec 8, 2023
Merged
[FIX] Ignore real and imaginary scans in ADNI #1029
NicolasGensollen
merged 5 commits into
aramis-lab:dev
from
NicolasGensollen:ignore-real-and-imaginary-scans-adni
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rated by dcm2niix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Just a minor type hint missing !
NicolasGensollen
commented
Dec 5, 2023
MatthieuJoulot
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NicolasGensollen !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a possible solution for the problem described in #1014
Images for which dcm2niix outputs a
real
orimaginary
suffix are removed and a warning is given to the user.The PR also proposes some slight refactoring of the underlying function (mainly using pathlib for path-related operations as well as adjusting some logging levels).