Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ignore real and imaginary scans in ADNI #1029

Conversation

NicolasGensollen
Copy link
Member

This PR proposes a possible solution for the problem described in #1014

Images for which dcm2niix outputs a real or imaginary suffix are removed and a warning is given to the user.

The PR also proposes some slight refactoring of the underlying function (mainly using pathlib for path-related operations as well as adjusting some logging levels).

Copy link
Contributor

@MatthieuJoulot MatthieuJoulot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Just a minor type hint missing !

clinica/iotools/converters/adni_to_bids/adni_utils.py Outdated Show resolved Hide resolved
@NicolasGensollen NicolasGensollen marked this pull request as ready for review December 5, 2023 16:37
Copy link
Contributor

@MatthieuJoulot MatthieuJoulot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolasGensollen NicolasGensollen self-assigned this Dec 7, 2023
@NicolasGensollen NicolasGensollen merged commit a19bade into aramis-lab:dev Dec 8, 2023
13 of 17 checks passed
@NicolasGensollen NicolasGensollen deleted the ignore-real-and-imaginary-scans-adni branch December 8, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants