Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "real" and "imaginary" file endings to return fmap in adni_utils.py #1177

Closed
wants to merge 1 commit into from

Conversation

likeajumprope
Copy link

@likeajumprope likeajumprope commented May 8, 2024

Adding file endings "real" and "imaginary" to adni_utils.py to return "fmap"; to cover all file endings.
This allows running over:

"... fmap_ e2_imaginary.json"
"... fmap_e2_real.json"

and not throw an error.

This PR was mentioned in #1175.

@likeajumprope likeajumprope changed the title add "real" and "imaginary" file endings to adni_utils.py add "real" and "imaginary" file endings to return fmap in adni_utils.py May 8, 2024
@NicolasGensollen
Copy link
Member

Hi @likeajumprope

I'm going to close this PR as the real and imaginary files need to be ignored as they result from a bad conversion by dcm2niix.
In addition these two suffixes aren't BIDS compliant and would break the current code in many ways.
Feel free to re-open this PR, or open a dedicated issue if we misunderstood something here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants