Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add function log_and_raise #1238

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

NicolasGensollen
Copy link
Member

Very small PR which proposes to add a log_and_raise function to clinica.utils.stream to automatically log (using cprint) and raise a given error message. This will be useful for example in #1237

Also modifies adni_json.py where a less generic function was used to log and raise a specific error type.

@NicolasGensollen NicolasGensollen self-assigned this Jul 17, 2024
@NicolasGensollen NicolasGensollen marked this pull request as ready for review July 17, 2024 12:05
Copy link
Contributor

@AliceJoubert AliceJoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @NicolasGensollen

@NicolasGensollen NicolasGensollen merged commit ca77bab into aramis-lab:dev Jul 18, 2024
13 of 15 checks passed
@NicolasGensollen NicolasGensollen deleted the add-log-and-raise branch July 18, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants