Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Refactor UKB-To-BIDS documentation page #1284

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

AliceJoubert
Copy link
Contributor

No description provided.

@AliceJoubert AliceJoubert added the doc Documentation (wiki, source code, etc.) label Sep 5, 2024
@AliceJoubert AliceJoubert self-assigned this Sep 5, 2024
@AliceJoubert AliceJoubert marked this pull request as ready for review September 6, 2024 15:19
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AliceJoubert !
I think it looks great ! I just have some questions and a few small suggestions.

docs/Converters/UKBtoBIDS.md Outdated Show resolved Hide resolved
docs/Converters/UKBtoBIDS.md Show resolved Hide resolved
docs/Converters/UKBtoBIDS.md Outdated Show resolved Hide resolved
docs/Converters/UKBtoBIDS.md Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
@AliceJoubert
Copy link
Contributor Author

Thanks for the review @NicolasGensollen ! Do you see anything else ?

Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit 01f9061 into aramis-lab:dev Sep 9, 2024
13 of 15 checks passed
@AliceJoubert AliceJoubert deleted the ukb_docs branch September 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation (wiki, source code, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants