Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: max_allowed_packet is set by the user #312

Merged
merged 1 commit into from
Jul 26, 2022
Merged

feat: max_allowed_packet is set by the user #312

merged 1 commit into from
Jul 26, 2022
+2 −89

Conversation

Penglq
Copy link
Contributor

@Penglq Penglq commented Jul 24, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #292

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-commenter
Copy link

Codecov Report

Merging #312 (a363b4c) into master (6f5a27d) will increase coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   39.66%   39.80%   +0.14%     
==========================================
  Files          99       99              
  Lines       13736    13683      -53     
==========================================
- Hits         5448     5447       -1     
+ Misses       7621     7569      -52     
  Partials      667      667
Impacted Files Coverage Δ
pkg/mysql/client.go 34.69% <0.00%> (+2.49%) ⬆️
pkg/dataset/priority_queue.go 66.30% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5a27d...a363b4c. Read the comment docs.

@dongzl dongzl added refactor Refactor code protocol MySQL Protocol. labels Jul 25, 2022
@jjeffcaii jjeffcaii merged commit b04366f into arana-db:master Jul 26, 2022
binbin0325 pushed a commit to binbin0325/arana that referenced this pull request Jul 26, 2022
@Penglq
feat: max_allowed_packet is set by the user (arana-db#312)
3b94229
binbin0325 pushed a commit to binbin0325/arana that referenced this pull request Jul 26, 2022
@Penglq
feat: max_allowed_packet is set by the user (arana-db#312)
caf6cfe
dongzl added a commit that referenced this pull request Jul 27, 2022
@chuntaojun @dongzl
@Mulavar @Penglq
Merge master (#320)
0972d5a 
* add unit test. (#306)

* Add: add Range interface mock.

* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: #292 #281 (#297)

* insert multi value at once request, throw error msg when any row error fix: #287 (#313)

* feat: support show status (#309)

* feat: max_allowed_packet is set by the user (#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>
chuntaojun added a commit to chuntaojun/arana that referenced this pull request Jul 27, 2022
@chuntaojun @dongzl
@Mulavar @Penglq
Merge master (arana-db#320)
63c784d 
* add unit test. (arana-db#306)

* Add: add Range interface mock.

* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (arana-db#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: arana-db#292 arana-db#281 (arana-db#297)

* insert multi value at once request, throw error msg when any row error fix: arana-db#287 (arana-db#313)

* feat: support show status (arana-db#309)

* feat: max_allowed_packet is set by the user (arana-db#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>
dongzl added a commit that referenced this pull request Jul 29, 2022
@chuntaojun @jjeffcaii
@dongzl @Mulavar @Penglq
Feature/sequence (#322)
e0d604b 
* [ISSUE #94] Feat sequence (#211)

* feat: support sequence

* feat: none

* feat: snowflake seqneuce finish

* fix: add sequence unit test

* feat: support sequence

* chore: remove test.log

* fix: fix cr issue

* fix: fix integration_test fail

* style: fix code style

* docs: update code comment

* fix: fix pr issue

* fix: fix sql scriip style

* test: add unit test

* docs: fix sql script comment

* refactor: update auto_increment to sequence

* fix: fix cr issue

* refactor: refactor sequence create mgr

* style: fmt code style

* fix: fix pr issue

* docs: fix code comment

* fix: fix cr issue

* fix: fix sequence create table sql (#266)

* fix: compatible with new optimizer structure

* fix ut

* fix: fix sequence bug (#302)

* fix: fix sequence bug

* refactor: use lazy creat sequence

* style: fix code style

* docs: update code comment

* fix: fix pr issue

* fix: remove unuse test file

* Fix new sequence (#316)

* fix: fix sequence bug

* refactor: use lazy creat sequence

* style: fix code style

* docs: update code comment

* fix: fix pr issue

* fix: remove unuse test file

* fix: fix snowflake all even number bug

* Merge master (#320)

* add unit test. (#306)

* Add: add Range interface mock.

* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: #292 #281 (#297)

* insert multi value at once request, throw error msg when any row error fix: #287 (#313)

* feat: support show status (#309)

* feat: max_allowed_packet is set by the user (#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

* style: fix code style

* ci: fix ci bug

* ci: fix ci bug

* ci: fix ci error

* fix: fix ci bug

* fix: fix runtime.Runtime use

Co-authored-by: Jeffsky <jjeffcaii@outlook.com>
Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>
binbin0325 pushed a commit to binbin0325/arana that referenced this pull request Jul 31, 2022
@binbin0325
hints fullscan
fdb0977 
* Add: add test case for iterator.

* fix: format import.

* fix: fix test case error.

* Add: add test case for shard_expr.

* Add: add license header.

* Add: add new test case.

* fix: fix import format.

* refactor schemanager cache to lru cache (arana-db#246)

Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>

* optimize maxAllowedPacket config fix: arana-db#292 arana-db#281 (arana-db#297)

* insert multi value at once request, throw error msg when any row error fix: arana-db#287 (arana-db#313)

* feat: support show status (arana-db#309)

* feat: max_allowed_packet is set by the user (arana-db#312)

Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

* style: fix code style

* ci: fix ci bug

* ci: fix ci bug

* ci: fix ci error

* fix: fix ci bug

* fix: fix runtime.Runtime use

Co-authored-by: Jeffsky <jjeffcaii@outlook.com>
Co-authored-by: Zonglei Dong <dongzonglei@apache.org>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: Dong Jianhui <dongjianhui03@meituan.com>
Co-authored-by: adair peng <luqiangpeng5945@gmail.com>

debug: listen capabilities fix:arana-db#317 (arana-db#328)

feat: support "show collation" SQL statement. (arana-db#307)

chore: add unit test. (arana-db#323)

* Add: add unit test for api.go.

* Add: add license header.

* fix: fix import format.

* fix: refactor mock file directory.

* fix: fix import format.

* fix: fix path name.

* fix: fix test config file content.

* add: add test case for file.go .

* fix: fix import format.

* fix: fix file format.

* fix: fix code review problem.

* fix: fix error test case.

* fix: fix bootstrap test config.

* fix: fix test config data.

commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@dongzl dongzl dongzl approved these changes

@jjeffcaii jjeffcaii jjeffcaii approved these changes

@baerwang baerwang Awaiting requested review from baerwang

@chuntaojun chuntaojun Awaiting requested review from chuntaojun

@georgehao georgehao Awaiting requested review from georgehao

Assignees
No one assigned
Labels
protocol MySQL Protocol. refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Optimize maxAllowedPacket config.
5 participants
@Penglq @codecov-commenter @jjeffcaii @dongzl @AlexStocks