Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mysql lpad function #566

Merged
merged 4 commits into from
Jan 2, 2023

Conversation

mengchuang123
Copy link
Contributor

support mysql left padding function

What this PR does:

Which issue(s) this PR fixes:

Fixes # #563

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


support mysql left padding function
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Base: 35.28% // Head: 35.79% // Increases project coverage by +0.50% 🎉

Coverage data is based on head (555a105) compared to base (88a5f06).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   35.28%   35.79%   +0.50%     
==========================================
  Files         182      186       +4     
  Lines       21131    21244     +113     
==========================================
+ Hits         7456     7604     +148     
+ Misses      12837    12762      -75     
- Partials      838      878      +40     
Impacted Files Coverage Δ
pkg/runtime/function/lpad.go 66.66% <66.66%> (ø)
pkg/runtime/function/substring.go 75.00% <0.00%> (ø)
pkg/runtime/function/rtrim.go 75.00% <0.00%> (ø)
pkg/runtime/function/ltrim.go 75.00% <0.00%> (ø)
pkg/dataset/priority_queue.go 77.61% <0.00%> (+1.49%) ⬆️
pkg/boot/boot.go 52.17% <0.00%> (+6.83%) ⬆️
pkg/boot/watcher.go 7.80% <0.00%> (+7.32%) ⬆️
pkg/boot/discovery_watch.go 24.74% <0.00%> (+24.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the SQL SQL support label Dec 4, 2022
@dongzl dongzl added this to the 0.2.0 milestone Dec 4, 2022
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 15b437d into arana-db:master Jan 2, 2023
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
* support mysql lpad function

support mysql left padding function

* Adapt to "NewValue"

* define "int64(len(StrRunes))" val et al.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants