Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD update #346

Merged
merged 8 commits into from
Jul 23, 2024
Merged

RTD update #346

merged 8 commits into from
Jul 23, 2024

Conversation

apetenchea
Copy link
Member

@apetenchea apetenchea commented Jul 17, 2024

Removal of Sphinx context injection at build time has little effect for us.
Read the blog post from Read The Docs for more information.

However, this PR also updates the way docs are being build:

  • We're using RTD build hook, which adds a new check for every PR (named docs/readthedocs.org:python-driver-for-arangodb). This comes with the park that we can now easily view the documentation build for every PR by clicking on details (a fake documentation page is generated).
  • The docs action is not needed to build the documentation anymore. However, we'll keep it around for now in order to run the docs tests.

@apetenchea apetenchea self-assigned this Jul 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (95b791c) to head (c6a86ce).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          26       26           
  Lines        4277     4277           
=======================================
  Hits         4104     4104           
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arango/request.py Outdated Show resolved Hide resolved
Copy link
Member

@aMahanna aMahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just left one small question

@apetenchea apetenchea merged commit 324eb66 into main Jul 23, 2024
37 checks passed
@apetenchea apetenchea deleted the feature/rtd-update branch July 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants