Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE-683] ignore unknown id on crud repo deleteById() #283

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[DE-683] ignore unknown id on crud repo deleteById() #283

merged 2 commits into from
Sep 12, 2023

Conversation

aburmeis
Copy link
Contributor

@aburmeis aburmeis commented Sep 9, 2023 •
edited
Loading

CrudRepository.deleteById() has a contract of ignoring unknown ids silently

@cla-bot cla-bot bot added the cla-signed label Sep 9, 2023
@aburmeis
Copy link
Contributor Author

aburmeis commented Sep 9, 2023

@rashtao would be great if this could be part of the 4.0 release, that's all

@rashtao rashtao self-assigned this Sep 12, 2023
@rashtao rashtao self-requested a review September 12, 2023 08:42
@rashtao rashtao changed the title ignore unknown id on crud repo deleteById() [DE-683] ignore unknown id on crud repo deleteById() Sep 12, 2023
rashtao
rashtao approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@rashtao rashtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced a new exception DocumentNotFoundException to further reduce the possibility of mistakes in future, i.e. translating other error nums to DataRetrievalFailureException.

@rashtao rashtao merged commit 8e9a2fe into arangodb:master Sep 12, 2023
@aburmeis aburmeis deleted the bugfix/deleteById-ignore-unknown branch September 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashtao rashtao rashtao approved these changes

Assignees

@rashtao rashtao

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aburmeis @rashtao