Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean repo #97

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Clean repo #97

wants to merge 8 commits into from

Conversation

whereswaldon
Copy link
Member

Feature/Fix explanation

The goal of this PR is to ensure that builds on Travis are clean (do not have the -modified suffix in their version. In an attempt to do this, this PR resets the version file after each build and locks us to a specific stable version of dep (to prevent rewriting Gopkg.lock).


Review required: @arborchat/devs

@whereswaldon whereswaldon requested a review from a team January 27, 2019 18:34
Copy link
Contributor

@jwhett jwhett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve, but would like to see it pass on travis; currently misbehaving.

#usage: ./build.sh <options for `go build`>

# use bash strict mode
set -euo pipefail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwhett jwhett self-assigned this Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants