Bug Fix: Crash, abnormal update while switching conversation Ids #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
dartpain
added
help wanted
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Basically conversationId is updated in two situations:
1. switching the conversation
2. streaming when data.type = 'id'
As per the current flow, there are following bugs:
While streaming, switching to New Chat, crashes the application
In case of New Chat, the conversations are not updating in the sidebar
Fix:
Pause the update of streaming query without pausing the fetchAnswer middleware explicitly.
* Set the status as idle for every update to conversationId
* Append the streaming answer to the response only when the status is not idle.
Why was this change needed? (You can also link to an open issue here)
- Fixes the root cause of the problem.