Namespaced scopes #167
Merged
Namespaced scopes #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
No deal-breakers necessarily, but I have a few pointed questions. Also, I think the code comments are a little uneven -- I think we have too many/unnecessary line comments and perhaps not enough function header comments. (And, I have a couple of coding suggestions/questions.)
mfleader
approved these changes
Apr 15, 2024
webbnh
approved these changes
Apr 16, 2024
dbutenhof
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This PR utilizes the namespaced scopes features added to the Go SDK.
It applies scopes from all of the steps.
The best examples are in the workflow_test.go file.
By contributing to this repository, I agree to the contribution guidelines.