Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to stage cancelled #173

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Transition to stage cancelled #173

merged 9 commits into from
Apr 25, 2024

Conversation

jaredoconnell
Copy link
Contributor

This fixes a potential deadlock in a specific case

By contributing to this repository, I agree to the contribution guidelines.

@jaredoconnell
Transition to stage cancelled
03ba315 
This fixes a potential deadlock in a specific case
webbnh
webbnh approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell; however, there are a couple of comments in the test which could be clearer.

workflow/workflow_test.go Outdated Show resolved Hide resolved
workflow/workflow_test.go Outdated Show resolved Hide resolved
@webbnh

This comment was marked as resolved.

Sign in to view
dbutenhof
dbutenhof approved these changes Apr 23, 2024
View reviewed changes
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, OK, I think. A comment or two wouldn't hurt.

@jaredoconnell
Copy link
Contributor Author

The linter isn't happy with you, presumably because of this and this, which I think I agree with...but I don't know why the linter doesn't mind these on the main branch.

In any case, I would either remove the directives or add a comment to them explaining why we are disabling the directive instead of fixing whatever the linter is complaining about.

Fixed. It's annoying when unrelated things break the linter in the CI. Likely a difference in version of the linter.

webbnh

This comment was marked as resolved.

Sign in to view

webbnh
webbnh approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jaredoconnell jaredoconnell merged commit d27afd7 into main Apr 25, 2024
5 checks passed
@jaredoconnell jaredoconnell deleted the fix-cancelled-step-deadlock branch April 25, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@dbutenhof dbutenhof dbutenhof approved these changes

@mfleader mfleader Awaiting requested review from mfleader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredoconnell @webbnh @dbutenhof