Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RootObject to improve validation #175

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

jaredoconnell
Copy link
Contributor

@jaredoconnell jaredoconnell commented Apr 22, 2024

Changes introduced with this PR

This will make it so there is not a segmentation fault when someone makes a schema mistake. It will still panic, though.


By contributing to this repository, I agree to the contribution guidelines.

Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I'm not a fan of panics due to user errors, it's about 235% better than a SIGSEGV. 😆

@jaredoconnell jaredoconnell merged commit 97f5031 into main Apr 23, 2024
5 checks passed
@jaredoconnell jaredoconnell deleted the use-rootobject-getter branch April 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants