Disabled steps #180
Merged
Disabled steps #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a potential deadlock in a specific case
dbutenhof
reviewed
May 2, 2024
dbutenhof
approved these changes
May 2, 2024
mfleader
reviewed
May 2, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
webbnh
approved these changes
May 4, 2024
There was a problem hiding this comment.
Looks good to go, except for one comment, but it's such a small thing that I'm going to "pre-resolve" it, in case you decide not to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This is the initial design. It does not provide a way to gracefully handle disabling yet, but that's out of scope of this PR.
Let me know if you see any missing test cases.
By contributing to this repository, I agree to the contribution guidelines.