Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] awesome-widgets 3.1.0 fails to build #87

Closed
protist opened this issue Apr 6, 2016 · 6 comments
Closed

[Regression] awesome-widgets 3.1.0 fails to build #87

protist opened this issue Apr 6, 2016 · 6 comments
Assignees
@arcan1s
Labels
bug

Comments

@protist
Copy link

protist commented Apr 6, 2016

I tried upgrading to the latest version 3.1.0, but it fails to build. I followed the instructions on the Readme, but it fails at the make step. Error logs here. I'm using Plasma 5, but it fails whether I use -DKDE_INSTALL_USE_QT_SYS_PATHS=ON in the previous step or not.
@revoluzzer
Copy link

i have the same problem with the aur/PKGBUILD-git and the source.

@protist
Copy link
Author

protist commented Apr 6, 2016

Yes, FWIW this originally failed for me with the (non-git) AUR plasma5-applet-awesome-widgets 3.0.1-1, but I could replicate the failure directly from upstream.

@arcan1s
Copy link
Owner

arcan1s commented Apr 6, 2016

sorry :( didnt rebuild it in clear chroot for some time, just found the same error while trying to build ubuntu packages

@arcan1s arcan1s self-assigned this Apr 6, 2016
@arcan1s arcan1s added the bug label Apr 6, 2016
@arcan1s
Copy link
Owner

arcan1s commented Apr 6, 2016

hmm, actually the error occurs only while using gcc, clang produces no errors :/

arcan1s added a commit that referenced this issue Apr 6, 2016
@arcan1s
release 3.1.1
e9146b3 
* translation update
* fix broken build with gcc (#87). The issue was reproduced only with
  gcc build and has been resolved by just replacing C-like `isnan` to
  `std::isnan`
@arcan1s arcan1s closed this as completed Apr 6, 2016
@arcan1s arcan1s mentioned this issue Apr 6, 2016
Merged
@protist
Copy link
Author

protist commented Apr 6, 2016

Thanks for the quick fix! I just realised you were the AUR maintainer too, so sorry for spamming you! :)

@protist
Copy link
Author

protist commented Apr 6, 2016

Also, I can confirm that it builds fine for me now (from the AUR package). Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arcan1s arcan1s

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@protist @arcan1s @revoluzzer