Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controlled-lists] Reference select widget assumes items have URIs #8

Closed
jacobtylerwalls opened this issue Jun 5, 2024 · 2 comments · Fixed by #17
Closed

[controlled-lists] Reference select widget assumes items have URIs #8

jacobtylerwalls opened this issue Jun 5, 2024 · 2 comments · Fixed by #17
Assignees

Comments

@jacobtylerwalls
Copy link
Member

Noticed today while showing archesproject/arches#10569 that the reference select widget ignores items without URIs. Suggest loosening this since we've currently modeled URIs as optional.

https://github.com/archesproject/arches/blob/0552f70c120ddfce3e5e785819a4ac47f2603c21/arches/app/media/js/viewmodels/reference-select.js#L111-L115

@jacobtylerwalls
Copy link
Member Author

@robgaston should we go ahead and make URIs optional for widget display, or should we hold off in case we decide to generate URIs on the fly?

@robgaston
Copy link
Member

@jacobtylerwalls I'm sort of thinking that they should remain "optional" for entry, but when they are not provided we should use a default which would just be the PUBLIC_SERVER_ADDRESS concatentated w/ the url to the list item itself. Perhaps it's best if newly created list items are automatically assigned this default entry and URIs are actually required on the model itself (thus we know they are always available on each record)

@jacobtylerwalls jacobtylerwalls self-assigned this Jul 10, 2024
jacobtylerwalls referenced this issue in archesproject/arches Jul 10, 2024
@jacobtylerwalls jacobtylerwalls transferred this issue from archesproject/arches Jul 30, 2024
jacobtylerwalls added a commit that referenced this issue Jul 30, 2024
robgaston added a commit that referenced this issue Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
2 participants