Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11764 fix frontend build with poetry or uv #11765

Conversation

danbentley
Copy link

Resolves #11764

The convention of naming a virtual environment ".venv" appears to have been adopted by the above package managers.

The fix addresses the issue of templates in directories that contain a dot (specifically for Arches installed with the above package managers) while ensuring that dotfiles, such as macOS' .DS_Store (#11094), are ignored.

Types of changes

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Amended the utility function responsible for locating JavaScript within Arches to ignore dotfiles but allow directories containing a dot (such as .venv):


        // Ignore dotfiles
        if (Path.basename(file).startsWith('.')) {
            return lookup;
        }

Couldn't find any tests relating to the build_development command but happy to add a test to ensure nothing is broken by this change.

Issues Solved

Closes #11764

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • [x ] dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • [x ] Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

Resolves archesproject#11764

The convention of naming a virtual environment "`.venv`" appears to have been adopted
by the above package managers.

The fix addresses the issue of templates in directories that contain a dot (specifically
for Arches installed with the above package managers) while ensuring that dotfiles, such
as macOS' .DS_Store (archesproject#11094), are ignored.
@danbentley danbentley force-pushed the 11764-fix-frontend-build-with-poetry-or-uv branch from d669c40 to b593cbb Compare February 4, 2025 12:57
@chrabyrd chrabyrd self-requested a review February 4, 2025 16:29
Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @danbentley !

Thanks for the contribution -- this looks good 👍

@chrabyrd chrabyrd merged commit 579c18f into archesproject:dev/7.6.x Feb 7, 2025
6 of 7 checks passed
@chrabyrd
Copy link
Contributor

chrabyrd commented Feb 7, 2025

I went ahead and updated the release file. We usually ask this gets updated with every contribution but I figured it'd be easy to roll out for this . Just info for next time 😄

Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants