Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dismissal and extra message on failed login alert #11767 #11768

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

jacobtylerwalls
Copy link
Member

Closes #11767

Copy link
Contributor

@phudson-he phudson-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @jacobtylerwalls will this make its way to 7.6?

@phudson-he phudson-he merged commit 6bc7ae5 into dev/8.0.x Feb 5, 2025
7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/fix-login-alert branch February 5, 2025 12:11
@jacobtylerwalls
Copy link
Member Author

Not unless it regressed newly in 7.6, but @chiatt could confirm.

@chiatt
Copy link
Member

chiatt commented Feb 5, 2025

I have to agree with @jacobtylerwalls. It doesn't appear to meet the criteria for a change to 7.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to dismiss alert upon incorrect sign-in
3 participants