-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dilation and dropout #4
Open
jmoso13
wants to merge
19
commits into
archinetai:main
Choose a base branch
from
jmoso13:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the residual units inside the UNet encoder and decoder blocks to follow more closely the encoder/decoder architecture described in both:
and
Specifically it adapts the internal residual units to follow an exponentially increasing dilation schedule by way of a dilation factor base (usually 3):
As well as adapting the second convolutional layer in the residual unit to use dilation=1 and kernel_size=1. This follows the residual units described in the papers above.
To optionally remove dilation from the blocks, use dilation factor of 1:
Additionally I have added dropout in the residual units for experimentation after the activation. I tried to adhere as closely as possible to the code style you have laid out, let me know if there are stylistic or other tweaks you'd like to see. Hopefully this is a useful contribution! I have already been experimenting in adding dilation to https://github.com/archinetai/audio-diffusion-pytorch using this update and will push a PR in that repo as well for controlling dilation factor and dropout for UNet use in diffusion.
🙏