Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lite #422

Merged
merged 12 commits into from
Feb 2, 2024
Merged

aws-lite #422

merged 12 commits into from
Feb 2, 2024

Conversation

ryanblock
Copy link
Member

Remove Node.js >= 18 conditional checks for a bunch of unit tests broken by AWS SDK v3

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from master
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

Remove Node.js >= 18 conditional checks for a bunch of unit tests broken by AWS SDK v3
@ryanblock ryanblock linked an issue Jan 3, 2024 that may be closed by this pull request
@ryanblock ryanblock changed the title Migration to aws-lite aws-lite Jan 3, 2024
@ryanblock ryanblock merged commit b4d6655 into main Feb 2, 2024
30 checks passed
@ryanblock ryanblock deleted the aws-lite branch February 2, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Transition Architect to using aws-lite
1 participant