Attempt to terminate via SIGINT + SIGTERM; should fix (or at least improve) #1479

changelog.md

@@ -2,6 +2,16 @@
 
 ---
 
+## [6.0.4] 2024-03-27
+
+### Fixed
+
+- Make a best effort attempt to terminate the process via `SIGINT` + `SIGTERM` termination signals; should fix (or at least improve) #1479
+  - Sandbox running via CLI will now forcefully terminate itself after 5 seconds if the termination routine has stalled out or takes too long
+  - Thanks @lpsinger + @courey!
+
+---
+
 ## [6.0.3] 2024-03-25
 
 ### Changed

src/cli/_stdin.js

@@ -4,6 +4,9 @@ let sandbox = require('../')
 module.exports = function handleStdin (params) {
   let { rehydrate, update, watcher } = params
 
+  let ending = false
+  let timeout
+
   // Listen for important keystrokes
   emitKeypressEvents(process.stdin)
   if (process.stdin.isTTY) {
@@ -34,15 +37,29 @@ module.exports = function handleStdin (params) {
       })
     }
     if (key.sequence === '\u0003' || key.sequence === '\u0004') {
-      if (watcher) {
-        watcher.close().then(end)
-      }
-      else end()
+      terminate('ctrl^c')
     }
   })
 
+  process.on('SIGINT', terminate)
+  process.on('SIGTERM', terminate)
+
+  function terminate (via) {
+    if (ending) return
+    else ending = true
+
+    timeout = setTimeout(() => {
+      update.err(`Process failed to gracefully exit in 5 seconds via ${via}, forcefully terminated`)
+      process.exit(1)
+    }, 5000)
+
+    if (watcher) watcher.close().then(end)
+    else end()
+  }
+
   function end () {
     sandbox.end(function (err) {
+      if (timeout) clearTimeout(timeout)
       if (err) {
         update.err(err)
         process.exit(1)