Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy Systems BIPV duplicate technologies #727

Closed
ChrisZenhub opened this issue Apr 6, 2022 · 8 comments · Fixed by #735
Closed

Energy Systems BIPV duplicate technologies #727

ChrisZenhub opened this issue Apr 6, 2022 · 8 comments · Fixed by #735
Assignees
Labels
bug 👾 a bug!!!

Comments

@ChrisZenhub
Copy link

No description provided.

@ChrisZenhub ChrisZenhub added the bug 👾 a bug!!! label Apr 6, 2022
@ChrisZenhub
Copy link
Author

There are duplicate technologies in BIPV:

image.png

@ChrisZenhub
Copy link
Author

... and we can't read the full text. When mouse hover-over, after a second, it should display the full text

@mmatache25
Copy link
Collaborator

  • not duplicates but different colours based on different energy efficiencies
  • tooltip over surface transmittance to choose the color
  • update the CSV
  • "duplicate technologies" only have one color per technology

@justinfmccarty please update CSV file

@justinfmccarty
Copy link
Contributor

@mmatache25 What would you like changed in the CSV?

@christophwaibel
Copy link
Contributor

christophwaibel commented May 4, 2022

@justinfmccarty per discussion, please rename the names in the Type column to make it clear what technology it is (red, steel, green, etc...). And we will keep the full list

https://github.com/architecture-building-systems/hive/blob/master/src/Hive.IO/Hive.IO/Resources/bipv_efficiency.csv

@christophwaibel
Copy link
Contributor

christophwaibel commented May 4, 2022

@mmatache25 it actually is a bug. The efficiency (and other) parameters are not changing in the EnergySystems hizard, no matter which BIPV Tech is selected

those should be two different items with different efficiencies:
image

image

also, the images should change, according to this list:

image

@christophwaibel
Copy link
Contributor

christophwaibel commented May 4, 2022

  • not duplicates but different colours based on different energy efficiencies
  • tooltip over surface transmittance to choose the color
  • update the CSV
  • "duplicate technologies" only have one color per technology

@justinfmccarty please update CSV file

@mmatache25 Tooltip string when hovering over Surface Transmittance text box on the Hizard: Parameter to control the transmittance through the cell covering layer - \"Durchlassgrad der Zellabdeckung\" (German)

@christophwaibel
Copy link
Contributor

@mmatache25 please also make these changes to the EnergySystems Hizard, when you are already at it:
Before:
image

Change to:
image

christophwaibel added a commit that referenced this issue May 16, 2022
…-Systems-BIPV-duplicate-technologies

#727 energy systems bipv duplicate technologies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 👾 a bug!!!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants