Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run SIA python scripts upon rebuild of Hive / creation of installer #607

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

maxenceryan
Copy link
Contributor

  • Builds the compile python scripts upon rebuilds
  • Assumes python is on PATH (as in, you are in a conda environment when running this)
  • the python scripts are for python 3! so i have two conda envs: hive with python 2 and hive3 with python 3. THis can easily be changed back to python 2 if needed. Only difference is where to put the encoding kwarg when writing the jsons
  • changes in python scripts are not relevant to issue, just separating out the concern of compiling SIA 2024 data vs compiligin/generating the schedules (since interpretation was needed). Should be part of adaptive comfort PR Sia380 - Adaptive comfort setbacks #595

Closes #605

@maxenceryan maxenceryan changed the title merge Run SIA python scripts upon rebuild of Hive / creation of installer Jun 25, 2021
@maxenceryan maxenceryan self-assigned this Jun 25, 2021
Copy link
Contributor

@christophwaibel christophwaibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update from master, and then you can merge. cheers

@maxenceryan maxenceryan merged commit 9617452 into master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build SIA JSON resources upon building installer
2 participants