-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
576 hotfix hourly energy systems #634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ads, it still uses hourly time series; visualizer should convert into monthly before displaying
…ly to monthly; not averaged
…lass and only converted into monthly in the Results class
maxenceryan
reviewed
Jul 9, 2021
maxenceryan
reviewed
Jul 9, 2021
maxenceryan
reviewed
Jul 9, 2021
maxenceryan
requested changes
Jul 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments, mostly refactoring suggestions
maxenceryan
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #576
Hourly loads and losses from
sia380.py
are now passed through the Hive core spaghetti until the Visualizer.The Visualizer still only displays monthly data, though. Hourly plots is a separate issue.
Remark: As already noticed by @maxenceryan , hourly simulation increases loads dramatically in comparison to the original monthly loads calculation