Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "default" construction type to use fixed time constant (tau) from SIA 2024 #653

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

maxenceryan
Copy link
Contributor

Issues

Closes #651

Description

  • add a "default" construction type option in the hizard
    • when selected, in the background a boolean called UseFixedTimeConstant is assigned to true
    • this boolean is passed similarly to RunAdaptiveComfort through the SIA distributor and into SIA 380 component
    • within sia380, the tau value from SIA 2024 rather than calculating it based on capacities (as is the case when selecting other construction types

image
image
image

results with default (fixed tau) selected:
image
results with superlightweight (more heating and cooling demand, as expected):
image

Checklist

…efault construction type assigned in hizard.
@maxenceryan maxenceryan self-assigned this Sep 23, 2021
@christophwaibel
Copy link
Contributor

christophwaibel commented Sep 25, 2021

@maxenceryan
unfortunately, there is still some significant difference in heating/cooling loads between v1.10.2 and this current PR. I do think, we should understand where this comes from, because there shouldn't be a difference.

I tried with the exercise file from the Hive online course, M04: https://moodle-app2.let.ethz.ch/mod/folder/view.php?id=590820 (files attached at the bottom of comment)

  • natural ventilation deactivated in new build
  • adaptive comfort connected to 80% range in v1.10.2 (and in new build)
  • variable tau set to "default" in new build

v1.10.2
v1 10 2_80percComf

new PR
PR

all files
files.zip

Copy link
Contributor

@christophwaibel christophwaibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment #653 (comment)

@maxenceryan
Copy link
Contributor Author

maxenceryan commented Sep 28, 2021

@christophwaibel

OK so I dug through all the changes one by one in sia380 but, given the same inputs, I could not find significant differences (apart from floating point errors). I tried this out outside of grasshopper with the same argument values for both the PR and v10.2.

Then in grasshopper, i checked the inputs to both GH files. One of them actually had adaptive comfort bounds set to 90, so I changed it to 80 as you described. I then compared inputs in both files and although there are many differences (additional SIA room properties, rearranged room_schedules JSON, surface_types by component instead of just transp/opaque), the only major difference is the zone floor area.

We at some point implemented a net zone area based on SIA recommendations of multiplying the gross floor area by 0.9 (see commit 19e19d7). You'll notice the difference in floor_area of the two GH files. The repercussions are that Q_i, Q_Elec and Q_V go down as they are all tied to per m2 values from SIA. This then affects the eta_g values which in turn alter all other outputs of the sia380 module.

I've attached the inputs (except for the hourly temperatures and solar profiles, as those dont change) and outputs as JSONs so you can compare them, but you will find the Q_i from the different versions almost exactly get multiplied by 0.9.

So from what I can tell this is what is happening.
fixedtauPR_comparison_jsons.zip

@christophwaibel
Copy link
Contributor

ahhhh!!! totally forgot about that! thanks a lot for solving this mystery. I can properly describe it then in the next Release.

OK from my side to merge

@christophwaibel
Copy link
Contributor

hold up... but why are cooling loads going up though, in comparison to v.1.10.2?

@christophwaibel
Copy link
Contributor

ok according to the files you attached, loads do look ok in comparison between versions.
I must have overlooked something then in my fast grasshopper tests... maybe because at some point, we also fixed a bug where all construction U-values where identical?

@christophwaibel
Copy link
Contributor

GHfiles.zip

OK I made sure to have all parameters identical and I can now also reproduce similar results between both versions, with the difference being plausible explained by the reduced floor area in the new PR.

NOW I'm ok with merging ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hizard - Create a "default" construction type that takes tau from SIA 2024 (non-variable)
2 participants