-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of all EnergySystems and Solar/SolarTech Components to C# #722
Conversation
Solar Performance Reader currently broken
…er component not needed this way
…roblems with GhSolarUnobstructed and GhSumOverTimePeriod
…od in simple_pv.gh
@philipschulz as per discussion in our sprint today, can you clean up |
@christophwaibel cleaned up simple_pv.gh |
private void Load() | ||
{ | ||
string[] lines = System.IO.File.ReadAllLines("../Resources/performance_ratio.csv"); | ||
lines = lines.Skip(1).ToArray(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one causes a loading error. I assume, it works on your system because when you run it on debug mode, it references it from your development project folder, while, if you run Rhino regularly, it tries to look for it on the software installation folder (Program Files\Rhino...).
I am thinking, it would be better anyway to have the data be compiled into the .dll, instead of loading a csv everytime we open Grasshopper. Similar to how we do it in Hive.IO\EnergySystems
: there are jsons that are compiled from csvs. And the solution compiles these jsons into the dll
Object: GhPerformanceRatioList (level 1)
{
Ein Aufrufziel hat einen Ausnahmefehler verursacht.
TargetInvocationException
}
Object: GhPerformanceRatioList (level 2)
{
Ein Teil des Pfades "C:\Program Files\Rhino 6\Resources\performance_ratio.csv" konnte nicht gefunden werden.
DirectoryNotFoundException
}
… performance reader due to bug in current PR
…t component to load data from json
@christophwaibel Rewrote the PerformanceRatioList so that it loads from a compiled json instead of the csv :) Shouldn't crash anymore because of missing file paths |
thanks @philipschulz , works fine now! merging |
Migration of all EnergySystems and Solar/SolarTech Components to C#
Issues
Closes #697
closes #698
Description
Checklist