Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to ignore file timestamps and produce archives with consistent hash #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

redneckz
Copy link

Related to the following issue
#416

@redneckz
Copy link
Author

Hi @ctalkington , any progress on this PR?
I will appritiate any feedback from you or your team.

@@ -153,6 +153,44 @@ describe('archiver', function() {
});
});

describe('#options.noTimestamp', function() {
Copy link
Member

@ctalkington ctalkington Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe('#options.noTimestamp', function() {
describe('options.noTimestamps', function() {

@florian-g2
Copy link

Hey @ctalkington, are there any updates, or has this functionality already been implemented in some other way?

@kormide
Copy link

kormide commented Dec 24, 2022

This would be a very useful feature to have when building with Bazel, which relies on deterministic artifacts for good remote cache performance.

@kormide
Copy link

kormide commented Dec 25, 2022

Note that I was able to work around this by fixing the date in the file entry when appending to a zip:

zip.append(content, {name: "foo.txt", date: new Date(0)});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants