Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow queue callback function parameter #519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reabreu
Copy link

@reabreu reabreu commented May 28, 2021

Hello and thanks for your work!
I've added an optional callback parameter to the append function cause we needed it to handle backpressure on an intense export feature we're developing.
Please have a look and let me know if we can add it to the library.

@reabreu
Copy link
Author

reabreu commented May 28, 2021

Addresses #470 #414 #398 #385

@manglass
Copy link

Any word on this being merged?

@reabreu
Copy link
Author

reabreu commented Jan 23, 2023

Hey, no word yet.

Copy link

@manglass manglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending these points, I think this is an excellent addition to the library.

I will check-in with @ctalkington to see if a maintainer is available to accept the final 2 points.

[ ] Update README.md (see direct comment)
[ ] maintainer approves/denies chai-spies
[ ] maintainer approves/denies addition of yarn.lock

@@ -78,6 +78,12 @@ archive.directory('subdir/', false);
// append files from a glob pattern
archive.glob('file*.txt', {cwd:__dirname});

// append a file with a callback for when the queue has been processed.
// usefull for implementing backpressure prevention mechanisms
archive.file("file1.txt", { name: "file4.txt" }, () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[✓] creating this documentation is an excellent touch
[ ] it should be moved from the archive.file example to the archive.append example(s)

@@ -39,6 +39,7 @@
"devDependencies": {
"archiver-jsdoc-theme": "^1.1.3",
"chai": "^4.2.0",
"chai-spies": "^1.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[✓] I successfully ran the tests locally with this helper
[ ] It is up to the maintainer if they want to add a new library, or if they have other techniques for this type of test...

@ctalkington ctalkington self-assigned this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants