Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.3.1-dev] Last step fails, cannot set locale/timesyncd #908

Closed
Torxed opened this issue Jan 25, 2022 · 1 comment
Closed

[v2.3.1-dev] Last step fails, cannot set locale/timesyncd #908

Torxed opened this issue Jan 25, 2022 · 1 comment

Comments

@Torxed
Copy link
Member

Torxed commented Jan 25, 2022

screenshot

@Torxed Torxed added this to the v2.3.1 milestone Jan 25, 2022
@Torxed Torxed changed the title [v2.3.1-dev] Last step fails, cannot set locale [v2.3.1-dev] Last step fails, cannot set locale/timesyncd Jan 25, 2022
Torxed added a commit that referenced this issue Jan 25, 2022
@Torxed
Copy link
Member Author

Torxed commented Jan 25, 2022

Solved with a general fix in 4f0ab32

@Torxed Torxed closed this as completed Jan 25, 2022
Torxed added a commit that referenced this issue Jan 26, 2022
* Added missing import

* Brought back the mounting of subvolumes, or at least the beginning of it. Improved some logging and decreased the usage of try/except where unessecary (we can catch it higher up without catching and raising the same thing.

* Trying to flatten the mount information to allow for sorted subvolume mounting. Still got issues.

* Re-worked mountpoints logic to be a flat dictionary structure, where all subvolumes are mountpoint targets, but with relevant information. Had to work that into Partition().mount to support re-mounting a partition multiple times. That will have to be cleaned up.

* Changed the default timeout to 15 as per the ISO

* Corrected a path when creating loopdev name.

* Added some debugging/warning

* Fixed a path lookup issue

* Added some debugging

* Added more debugging

* Removed excessive luks add_key() and crypttab() entries being generated by subvolumes.

* Added more debugging

* Avoiding excessive keyfile usage for partitions. Also added some debugging for BlockDevice.

* Added more debugging

* Added debugging and a hack to find /dev/sda from /dev/sda2

* Fixed ugly hack to use /dev/sdX instead of just sdX

* Inconsistency in lsblk -no pkname made sorting a bit tricky, resorting to shortest string wins.

* Tweak lookup

* Tweak lookup

* Added more debugging

* Had to filter lsblk output because some entries are empty rows

* Syntax issue

* Added a comment clarifying the many steps of partition->blockdevice logic.

* Added debug information

* Added debug information

* Added debug information

* Fixed issue #908

* Added subvolume support for grub. Also added check to see if grub is installed before installing it (to avoid multiple calls to pacstrap even tho it doesn't hurt)

* Modified 'sed' to use % as divider, since the replacement string can contain '/'

* Added debugging

* Testing GRUB with /boot/efi instead (might revert)

* Reverted /boot/efi for GRUB. Did no difference.

* Flake8 fix

* Testing --removable from #793 if it solves the UEFI issue

* Removing --remoable and pulling it from #793 for tracability

* Update installer.py (#1) (#793)

Added "--removable" after "--bootloader-id=GRUB" on Line 669, because it would throw an input/output error without it on my laptop

* Remove debug information

Co-authored-by: OneLongneck <95297344+OneLongneck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant