Fix most mypy errors in archinstall/scripts/, docs/, and the __init__ file #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torxed
approved these changes
Aug 27, 2024
correctmost
force-pushed
the
cm/mypy-scripts
branch
from
0d74957
to
040f8bc
Compare
1 task
svartkanin
requested changes
Aug 28, 2024
|
It looks like a permissions error: Have you seen similar failures before? |
|
Hmm interesting, @Torxed any ideas? I don't think this is related to the PR in any case so we can probably merge this for now |
svartkanin
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR fixes more of the simple mypy errors in the codebase. There are still ~150 left.
Tests and Checks