Add type hints to all functions in cleanup-list script #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxboron
approved these changes
May 20, 2023
jelly
approved these changes
May 22, 2023
| @@ -37,7 +38,8 @@ def parse_repo(dbpath): | |||
| pkgid = tarinfo.name | |||
| desc_tar = repodb.getmember(os.path.join(pkgid, "desc")) | |||
| desc_file = repodb.extractfile(desc_tar) | |||
| desc_file = io.TextIOWrapper(io.BytesIO(desc_file.read()), encoding="UTF-8") | |||
| desc_file = io.TextIOWrapper(io.BytesIO( | |||
| desc_file.read()), encoding="UTF-8") | |||
There was a problem hiding this comment.
For the next PR, please leave out the line length changes. I know we don't have a set up any linting configuration however this PR is about typing not pep8 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! I've added some type hints to the cleanup-list python script to make development easier. I plan on adding type hints to all functions in all python scripts in the repo(so I wouldn't merge yet).
Have a Great Day!