Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild todo pkgctl #69

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Rebuild todo pkgctl #69

merged 3 commits into from
Jun 17, 2024

Conversation

jelly
Copy link
Member

@jelly jelly commented Apr 4, 2024

No description provided.

package/rebuild-todo Outdated Show resolved Hide resolved
@christian-heusel
Copy link
Member

So whats the path forward here? 🤔 Do we update the standalone rebuild todo here or do we integrate it into pkgctl (as I have started in https://gitlab.archlinux.org/archlinux/devtools/-/merge_requests/192)

@anthraxx
Copy link
Member

anthraxx commented May 17, 2024 via email

@jelly
Copy link
Member Author

jelly commented May 18, 2024

So whats the path forward here? 🤔 Do we update the standalone rebuild todo here or do we integrate it into pkgctl (as I have started in https://gitlab.archlinux.org/archlinux/devtools/-/merge_requests/192)

As stated on Matrix, I am happy test that MR and test it. Moving this into pkgctl is obviously what we want 🚀

Please let's have it in pkgctl, but afaik we need to request ArchWeb support for more advanced Apis besides just query and rebuild a Todo.

That is in no way a blocker, the current script does not use an advanced API.

@jelly jelly requested review from dvzrv and Foxboron June 4, 2024 18:32
@jelly jelly marked this pull request as ready for review June 4, 2024 18:32
Copy link
Member

@christian-heusel christian-heusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have replaced the tabs in the code area, because they messed with the alignment 😄 Code looks good tho!

@christian-heusel christian-heusel merged commit d50ec7b into master Jun 17, 2024
1 check passed
@svenstaro svenstaro deleted the rebuild-todo-pkgctl branch June 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants