Issue #4: Added From trait
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `from()` and `tryFrom()` methods to pure enums, and the `fromName()` and `tryFromName()` methods for all enum types.
stancl
reviewed
Mar 13, 2022
stancl
reviewed
Mar 14, 2022
stancl
reviewed
Mar 14, 2022
stancl
reviewed
Mar 14, 2022
stancl
reviewed
Mar 14, 2022
samlev
force-pushed
the
issues/#4_fromName_tryFromName
branch
from
1ff3cc8 to
ce6c664
Compare
Dropped support for fragile indexes on pure enums
samlev
force-pushed
the
issues/#4_fromName_tryFromName
branch
from
ce6c664 to
ad1e07c
Compare
|
@samlev Can you mark the implemented reviews as "resolved"? So that I can see if there's anything missing |
|
Also in #6 |
|
@stancl done |
stancl
reviewed
Mar 23, 2022
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at @stancl's suggestion in Issue #4, I've added the
Fromtrait.This adds the
from()andtryFrom()methods to pure enums, and thefromName()andtryFromName()methods for all enum types.