[2.x] Don't purge central connections #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
The
endTenancy()
method (indirectly) callsDatabaseManager::reconnect()
which reconnects the default database back to the central database. That method purges the connection that we are switching to - this makes sense in case of switching tenants, to purge the 'tenant' connection, but in case of ending tenancy, this purges the central connection, resulting inDatabaseStorageDriver::$centralDatabase->getPdo()
returning null, making it unable to delete tenants after tenancy was ended (such as in tests'tearDown()
).TODO: