Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3.0] Make DB creation optional #299

Merged
merged 1 commit into from
Feb 26, 2020
Merged

[2.3.0] Make DB creation optional #299

merged 1 commit into from
Feb 26, 2020

Conversation

stancl
Copy link
Member

@stancl stancl commented Feb 26, 2020

Resolves #296

DB creation can be disabled for all tenants (tenancy.create_database config), or for individual tenants during tenant creation:

Tenant::new()->withData([
    '_tenancy_create_database' => false,
])->save();

@stancl stancl added this to the 2.3.0 milestone Feb 26, 2020
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #299 into 2.x will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #299      +/-   ##
============================================
+ Coverage     87.45%   87.51%   +0.05%     
- Complexity      381      384       +3     
============================================
  Files            58       58              
  Lines          1108     1113       +5     
============================================
+ Hits            969      974       +5     
  Misses          139      139
Impacted Files Coverage Δ Complexity Δ
src/TenantManager.php 95.77% <100%> (+0.15%) 52 <2> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb743f...3f1fed0. Read the comment docs.

@stancl stancl merged commit 98ce0ee into 2.x Feb 26, 2020
@stancl stancl deleted the optional-db-creation branch February 26, 2020 07:49
@stancl stancl mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional database creation
1 participant