Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse middlewares order before prepend #479

Merged
merged 1 commit into from
Aug 18, 2020
Merged

reverse middlewares order before prepend #479

merged 1 commit into from
Aug 18, 2020

Conversation

bepsvpt
Copy link
Contributor

@bepsvpt bepsvpt commented Aug 18, 2020

prependToMiddlewarePriority will add the middleware to first one. If it just iterates the $tenancyMiddleware array. The final middleware order will be incorrect.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #479 into 3.x will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #479      +/-   ##
============================================
+ Coverage     86.81%   86.92%   +0.11%     
  Complexity      369      369              
============================================
  Files           103      103              
  Lines          1069     1078       +9     
============================================
+ Hits            928      937       +9     
  Misses          141      141              
Impacted Files Coverage Δ Complexity Δ
src/Features/TenantConfig.php 100.00% <0.00%> (ø) 9.00% <0.00%> (ø%)
src/Bootstrappers/QueueTenancyBootstrapper.php 90.00% <0.00%> (+0.34%) 13.00% <0.00%> (ø%)
src/TenancyServiceProvider.php 96.55% <0.00%> (+0.39%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6ff33...c3e6964. Read the comment docs.

@stancl stancl merged commit 1ff82fb into archtechx:3.x Aug 18, 2020
@stancl
Copy link
Member

stancl commented Aug 18, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants