Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminating pipelines #527

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Terminating pipelines #527

merged 2 commits into from
Nov 15, 2020

Conversation

stancl
Copy link
Member

@stancl stancl commented Nov 15, 2020

Fixes #514

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #527 (e4c672d) into 3.x (dd1b7fc) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #527      +/-   ##
============================================
+ Coverage     86.85%   87.04%   +0.18%     
- Complexity      364      366       +2     
============================================
  Files           103      103              
  Lines          1080     1088       +8     
============================================
+ Hits            938      947       +9     
+ Misses          142      141       -1     
Impacted Files Coverage Δ Complexity Δ
src/Jobs/CreateDatabase.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/Database/Concerns/TenantRun.php 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
src/Exceptions/TenantCouldNotBeIdentifiedById.php 0.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
src/Tenancy.php 92.59% <0.00%> (+1.10%) 22.00% <0.00%> (+2.00%)
src/Bootstrappers/QueueTenancyBootstrapper.php 93.33% <0.00%> (+3.33%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1b7fc...e4c672d. Read the comment docs.

@stancl stancl merged commit 126afcd into 3.x Nov 15, 2020
@stancl stancl deleted the terminating-pipelines branch November 15, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs subsequent to Jobs\CreateDatabase, doesn't respect tenany_create_database = false
1 participant