Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed array to string conversion #718

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Fixed array to string conversion #718

merged 2 commits into from
Dec 25, 2021

Conversation

kg-bot
Copy link
Contributor

@kg-bot kg-bot commented Sep 14, 2021

Previous code would give this warning before actually showing exception message
<warning>PHP Warning: Array to string conversion in .../vendor/stancl/tenancy/src/CacheManager.php on line 24</warning>

kg-bot and others added 2 commits September 14, 2021 11:40
Previous code would give this warning before actually showing exception message
`<warning>PHP Warning:  Array to string conversion in .../vendor/stancl/tenancy/src/CacheManager.php on line 24</warning>`
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #718 (c310e1d) into 3.x (20e1fa1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #718      +/-   ##
============================================
+ Coverage     87.02%   87.03%   +0.01%     
  Complexity      372      372              
============================================
  Files           103      103              
  Lines          1102     1103       +1     
============================================
+ Hits            959      960       +1     
  Misses          143      143              
Impacted Files Coverage Δ
src/CacheManager.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e1fa1...c310e1d. Read the comment docs.

@stancl stancl merged commit 435d852 into archtechx:3.x Dec 25, 2021
@stancl
Copy link
Member

stancl commented Dec 25, 2021

Thanks!

viicslen pushed a commit to viicslen/tenancy that referenced this pull request Feb 17, 2022
* Fixed array to string conversion

Previous code would give this warning before actually showing exception message
`<warning>PHP Warning:  Array to string conversion in .../vendor/stancl/tenancy/src/CacheManager.php on line 24</warning>`

* Update variable & syntax

Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants