Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass in all app keepers to the upgrade handler #456

Closed
spoo-bar opened this issue Sep 19, 2023 · 0 comments · Fixed by #457
Closed

feat: pass in all app keepers to the upgrade handler #456

spoo-bar opened this issue Sep 19, 2023 · 0 comments · Fixed by #457
Assignees

Comments

@spoo-bar
Copy link
Contributor

None of the app keepers were passed on to the upgrade handler pre v4.0.1. This hadn't been needed for any upgrades before.
#438 required passing of account keeper to the upgrade handler as the fee_collector account permissions had to be modified as done so in #437

However, due to the urgency of the issue at the time, the hardcoded approach of just passing the account keeper was taken. Now, we need to refactor the upgrade handlers and app.go to allow a more robust way to pass down all the app keepers so modifications can be make during upgrade process.

This is specifically needed for the sdk v0.47 upgrade as the x/gov params need to be updated as well as the params subspace migrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant