Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modifying the upgrade handlers to pass in all the app keepers instead of just the account keeper #457

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

spoo-bar
Copy link
Contributor

Closes: #456

  • Create a new struct which holds all the archway app keepers called ArchwayKeepers
  • Pass in this struct to the upgrade handlers

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 78.94% and project coverage change: +0.01% 🎉

Comparison is base (64380c2) 69.52% compared to head (f574495) 69.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   69.52%   69.54%   +0.01%     
==========================================
  Files          68       68              
  Lines        4023     4025       +2     
==========================================
+ Hits         2797     2799       +2     
  Misses       1128     1128              
  Partials       98       98              
Files Changed Coverage Δ
app/test_access.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.62% <0.00%> (ø)
app/export.go 12.30% <4.16%> (ø)
app/app_upgrades.go 61.90% <75.00%> (ø)
app/app.go 90.64% <98.47%> (+0.01%) ⬆️
app/upgrades/4_0_2/upgrades.go 66.66% <100.00%> (+1.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spoo-bar spoo-bar marked this pull request as ready for review September 19, 2023 10:45
@spoo-bar spoo-bar requested a review from a team as a code owner September 19, 2023 10:45
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoo-bar spoo-bar merged commit 2be1f72 into main Sep 20, 2023
9 checks passed
@spoo-bar spoo-bar deleted the spoorthi/upgrade-handler-pass-all-keepers branch September 20, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: pass in all app keepers to the upgrade handler
2 participants