chore: Post release maintenance #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 69.54% 69.54%
=======================================
Files 67 67
Lines 4006 4006
=======================================
Hits 2786 2786
Misses 1124 1124
Partials 96 96
☔ View full report in Codecov by Sentry. |
fdymylja
approved these changes
Aug 25, 2023
spoo-bar
added
the
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a chain upgrade test #430, this forces our repository to always have an active upgrade handler. With this PR, I propose that we have a
latestupgrade handler where all the upcoming upgrade logic goes into. This way any missing upgrade handling will be caught immediately by the developer who was working on the feature, as opposed to whoever adds in the upgrade handler prior to release. Whenever we decide to cut a release, we can rename the upgrade handler fromlatesttov5.0.0or something like that.One overhead with this to keep track of is that once we tag a release, we would have to do a maintenance PR like this which creates a new upgrade handler post release.