feat: add containerized localnet #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this script is no longer working and has been deprecated by scripts/localnet.sh
- change to use bash script instead of sh to allow more refined syntax - set archwayd process to listen all addresses instead of localhost - set BINARY path dependent on whether using containers or local
- use image based on TAG env variable, make file will set the tag automatically - enable 26656 also - change to use the new scripts path
- Update image version to alpine 3.18 - rename the debug image to dev - add bash and jq for dev purposes
jlehtimaki
force-pushed
the
localnet_enhancements
branch
2 times, most recently
from
21a1999
to
13dbe6b
Compare
jlehtimaki
force-pushed
the
localnet_enhancements
branch
from
13dbe6b
to
8983aa4
Compare
shahbazn
requested changes
Aug 31, 2023
There was a problem hiding this comment.
ran with the following diff
diff --git a/docker-compose.yaml b/docker-compose.yaml
index ab781ee..78cd0df 100644
--- a/docker-compose.yaml
+++ b/docker-compose.yaml
@@ -3,7 +3,7 @@ version: "3"
services:
node:
- image: ghcr.io/archway-network/archwayd-dev:${TAG}
+ image: ghcr.io/archway-network/archwayd-debug:latest
entrypoint:
- sh
- /opt/localnet.sh
and got the following error
❯ make localnet
# TAG=v4.0.0 docker-compose up
docker-compose up
WARN[0000] The "CONTINUE" variable is not set. Defaulting to a blank string.
[+] Running 0/1
⠿ node Error 1.2s
Error response from daemon: manifest unknown
make: *** [localnet] Error 18
How can I test this flow?
|
Note! that to test this out you need to change the |
Test and it works. Lets also please add docs to README.md to explain various methods of running the local networks |
zanicar
approved these changes
Sep 1, 2023
jlehtimaki
force-pushed
the
localnet_enhancements
branch
from
5e41b18
to
f3bb272
Compare
spoo-bar
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently users are not able to run their Archway localnet in containers by using
docker-composeThis PR will propose the following changes to fix these issues:
make localnetto start the containerized localnet with latest tagged image.make localnet-continueto start the shutdownarchway-node-1containerarchwayd-devinstead ofarchwayd-debugjqandbashwhich are used in thelocalnet.shscriptalpine:3.18localnet.shso that it will work with containerized environments as well