chore: fixing linter errors and tests #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txRes.Data is deprecated in favour of txRes.MsgResponses
spoo-bar
changed the title
spoo-bar
added a commit
that referenced
this pull request
Oct 13, 2023
* chore: replacing tendermint with cometbft (#433) * replacing tendermint refs with comet bft * replacing tm-db with cometbft-db * chore: Bumping sdk, wasmd and ibc-go (#435) * bumping sdk and wasmd and ibc versions * bumping ibc-go refs * chore: protobuf migration (#436) * protobuf migration * removing third_party/ * regenerating the proto files * RecordIDs.Ids is a repeated non-nullable native type, nullable=false has no effect * chore: fix broken upstream references (#450) updating upstream references for x/wasm. ibc-go, cosmos-sdk * chore: remove deprecated appmodule routes (#451) * remove genmsg deprecated route * remove rewards module deprecated route * remove tracking module deprecated route * chore: fixing all the modules and wasmbindings (#452) * fixing x/tracking module * fixing x/rewards module * fixing x/genmsg module * fixing genmsg module.go * fixing wasmbinding * chore: updating app wiring (#453) * fixing the upgrade handlers * fixing ante.go * fixing export.go * updating sim_test * fixing test_helpers * fixing some app.go stuff * custom "add-genesis-account" - removed as its not needed anymore * fixing root.go * fixing simulation test * fixing app.go * cleanup * chore: fixing e2e tests (#454) * fixing some e2e tests * fix more e2e tests * fixing ibc e2e stuff * updating changes from merge * fixing golang.org/x/exp ref. thx @fdymylja Co-Authored-By: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> * pr comment fixes --------- Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com> * chore: apply v46 changes (#455) * adding posthandler and reflection services * updating `sdkerrors.Wrap` with `errorsmod` * every cosmos message protobuf definition must be extended with a cosmos.msg.v1.signer option to signal the signer fields * better error for when post handler fails * running go mod tidy * registering query server after module init --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> * chore: apply v47 changes (#458) * adding crisis module store key * adding crisis module * adding consensus module * adding group module * adding nft module * fixing the merge * fixing gentx decoding * adding consensusparamtypes.StoreKey storekey && fixing staking keeper --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> * feat: bumping archway wasmd to v0.42.0 (#460) * updating to wasmd fork 0.42.0 * adding capability cosmwasm_1_4 * updating v1.4 libwasmvm checksums * chore: fixing linter errors and tests (#463) * fixing lint issues * fixing x/tracking tests * fixing app_test.go * replacing gov v1beta1 stuff with gov v1 * fixig app-upgrade-test txRes.Data is deprecated in favour of txRes.MsgResponses * removing depracated field usage * fixing ibctm not setup * making the flat fees e2e test simpler * fixing interchaintest chain upgrade * fixing TestTxFees thanks @fdymylja 🎉 * fixing more tests with initgenesis failure * fixing testcase to be compatible with this change cosmos/cosmos-sdk#9651 * removing the ante.DeductFeeDecorator as we alreayd have a custom one * fixing TestRewardsFlatFees * undo the mintkeeper fix * feat: adding upgrade handlers for sdk v47 (#464) * adding missing consensus keeper * adding upgrade handler stuff * oops messed the merge. fixing that --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> * feat: enabling rosetta (#466) adding rosetta * fix: updating logic for how we deal with infiniteGasMeter (#467) * handling behavior change in infinitegasmeter.Limit() * reflect no mo * feat: x/rewards param store migration (#468) * adding new msg proto * implementing UpdateParams msg * adding tests * adding module migrations forx/rewards * adding x/rewards to upgrade handlers * adding migratestore test * fixing lint * addressing pr review comments * Update CHANGELOG.md * feat: bumping archway wasmd to v0.43.0 (#470) * bumping wasmd fork to to v0.43.0 * updating wasmvm checksum * removing wasmd deprecated proposals as they arent in the codebase anymore * Updating changelog * test: fixing ibc conformance test (#469) fixing ibc conformance test. the custom genesis values are needed just for upgrade test --------- Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com> Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibctm.AppModuleBasic{}to app wiring as it was missingante.NewDeductFeeDecoratorwhich was added in chore: updating app wiring #453 Turns out the upgrade instructions of sdk 0.46x which said to replaceMempoolFeeDecoratorwithDeductFeeDecoratoris a bit of a problem. MempoolFeeDecorator used to check if the txfees met the requirements. DeductFeeDecorator does that PLUS deducts the fees too. Not directly substitutable now is it. So this new ante is now removed as we have a custom deduct fee ante handler anyway.I would like to end this PR by thanking the previous devs of this repo 🙏🏻 who have written such extensive tests that we caught so many gotcha scenarios. The tests fixing was a pain but it was a pain cuz it had such comprehensive coverage.