Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary characteristics for rate limits #202

Closed
blaine-arcjet opened this issue Feb 7, 2024 · 0 comments · Fixed by #203
Closed

Support arbitrary characteristics for rate limits #202

blaine-arcjet opened this issue Feb 7, 2024 · 0 comments · Fixed by #203
Assignees
@blaine-arcjet

Comments

@blaine-arcjet
Copy link
Contributor

This is supported via the API, but not supported via the SDK yet.
@blaine-arcjet blaine-arcjet self-assigned this Feb 7, 2024
@blaine-arcjet blaine-arcjet mentioned this issue Feb 7, 2024
Merged
@trunk-io trunk-io bot closed this as completed in #203 Feb 7, 2024
trunk-io bot pushed a commit that referenced this issue Feb 7, 2024
@blaine-arcjet
feat: Allow user-defined characteristics on rate limit options (#203)
dc5b001 
Closes #202 
Closes arcjet/arcjet#597

This adds TypeScript support for custom characteristics. While it was supported via the protocol, there was no indication to the user that they needed to add the field to every request.

By changing the types of our primitives, we can make the prop required on the request object (while filtering our well-known characteristics).

Draft because it needs some tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blaine-arcjet blaine-arcjet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow user-defined characteristics on rate limit options arcjet/arcjet-js
1 participant
@blaine-arcjet