Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query and cookies values via the protocol #212

Closed
blaine-arcjet opened this issue Feb 8, 2024 · 0 comments · Fixed by #214
Closed

Support query and cookies values via the protocol #212

blaine-arcjet opened this issue Feb 8, 2024 · 0 comments · Fixed by #214
Assignees
@blaine-arcjet

Comments

@blaine-arcjet
Copy link
Contributor

These were added to the protobuf but are unsupported via the SDK
@blaine-arcjet blaine-arcjet self-assigned this Feb 8, 2024
@blaine-arcjet blaine-arcjet mentioned this issue Feb 8, 2024
Merged
@trunk-io trunk-io bot closed this as completed in #214 Feb 8, 2024
trunk-io bot pushed a commit that referenced this issue Feb 8, 2024
@blaine-arcjet
feat: Support cookies and query via the protocol (#214)
ca0cd64 
Closes #212 

This adds support for `cookies` and `query` fields on the protocol.

Previously, we only worked with cookies on the headers, but for ease-of-use, I moved them to a separate `cookies` field.
And we used to include the querystring as part of the path, but I moved it to a separate `query` field. This should make the path displays a lot nicer.

I also noticed we were always passing an empty string for the protocol, so I made some changes to that since we're parsing the URL for the querystring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blaine-arcjet blaine-arcjet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support cookies and query via the protocol arcjet/arcjet-js
1 participant
@blaine-arcjet