Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user info catch cause redirection loops #153

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

motian
Copy link
Contributor

@motian motian commented Aug 5, 2022

Types of changes

  • New feature
  • Bug fix
  • Documentation change
  • Coding style change
  • Refactoring
  • Performance improvement
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change

Background and context

When userStore.info catch error, it will redirect to login page without clear login user info,
the next router will check isLogin(), because login user info is not clear, it will enter the catch again.
It may cause loop redirections, It's a better and more safe way to logout first before login actions

Solution

Logout before redirect to login page.

How is the change tested?

Changelog

Changelog(CN) Changelog(EN) Related issues

Checklist:

  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to master branch)

Other information

@sHow8e sHow8e merged commit 7c0e4f1 into arco-design:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants